Bug 29788: Make Koha::Item->safe_to_delete use Koha::Result::Boolean
authorJonathan Druart <jonathan.druart@bugs.koha-community.org>
Tue, 4 Jan 2022 14:34:48 +0000 (15:34 +0100)
committerFridolin Somers <fridolin.somers@biblibre.com>
Tue, 11 Jan 2022 22:38:35 +0000 (12:38 -1000)
commit21bc236e57bfaa46b80602e3d34f0f6f2175d14a
tree920f1ee9b1394461baef982a0ab3ddcaeab32245
parent381898d8ca2a78319dfc9e6d8e44564754172766
Bug 29788: Make Koha::Item->safe_to_delete use Koha::Result::Boolean

This patch reuse the (awesome) Koha::Result::Boolean module to retrieve
the return of Koha::Item->safe_to_delete.

Test plan:
Try to delete an item that has previously been checked out and confirm
that you are still blocked.
Try using the cronjobs, the item and biblio detail pages, as well as the
batch delete item tool.

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
C4/ImportBatch.pm
Koha/Acquisition/Order.pm
Koha/BackgroundJob/BatchDeleteBiblio.pm
Koha/BackgroundJob/BatchDeleteItem.pm
Koha/Item.pm
cataloguing/additem.pl
koha-tmpl/intranet-tmpl/prog/en/includes/html_helpers.inc
misc/cronjobs/delete_items.pl
misc/cronjobs/delete_records_via_leader.pl
t/db_dependent/Circulation/IsItemIssued.t
t/db_dependent/Koha/Item.t