Bug 24108: Make export file names consistent
authorNick Clemens <nick@bywatersolutions.com>
Mon, 11 Jan 2021 14:57:45 +0000 (14:57 +0000)
committerJonathan Druart <jonathan.druart@bugs.koha-community.org>
Wed, 17 Feb 2021 15:28:25 +0000 (16:28 +0100)
commit234cced91df51c2460152897f8c08e0b891d240c
tree59bd5afcf5140e74ae31eb75d065c9a6d6fc030d
parent0b1f162dccfe0f7edc1505fc0648dfa7f7792ca8
Bug 24108: Make export file names consistent

This patch renames the systempreference to be a bit clearer and uses
explicit options rather than a yes/no

Additionally it standardizes the export from the advanced cataloging editor
with that from the details page

To test:
 1 - Apply patches
 2 - Update database and restart all the things
 3 - Open a record in the advanced editor and save it as marc and xml
 4 - Note the file name is 'bib-{biblionumber.{format}'
 5 - Edit the syspref 'DefaultSaveRecordFileID' to be control number
 6 - Repeate 3-4 on a record with and without a control number
 7 - If control number present fiule name should be 'record-{controlnumber}.{format}'
 8 - Otherwise it should be as above
 9 - Repeat tests from the details page of a record
10 - Repeat tests from the opac details page of a record

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
catalogue/export.pl
installer/data/mysql/atomicupdate/bug_24108-add_SaveRecordbyControlNumber_syspref.perl [new file with mode: 0644]
installer/data/mysql/atomicupdate/bug_24108-add_SaveRecordbyControlNumber_syspref.sql [deleted file]
installer/data/mysql/mandatory/sysprefs.sql
koha-tmpl/intranet-tmpl/prog/en/includes/cateditor-ui.inc
koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/cataloguing.pref
opac/opac-export.pl