Bug 28617: Remove kohalib.pl and rely on PERL5LIB
authorJonathan Druart <jonathan.druart@bugs.koha-community.org>
Mon, 19 Jul 2021 09:00:52 +0000 (11:00 +0200)
committerFridolin Somers <fridolin.somers@biblibre.com>
Tue, 7 Dec 2021 22:16:28 +0000 (12:16 -1000)
commit238fabc4ab68735afc463a8d1ed53709c88dcd66
treeac3ebcc12b5969955e7c35a3a6f75c6a6439f735
parenta339a275031b19298632578c90c292361673f50d
Bug 28617: Remove kohalib.pl and rely on PERL5LIB

The purpose of this script was to load the relevant Koha lib for the
different scripts (installation, cronjob, CLI, etc.)
However it is not used consistently and we prefer to rely on PERL5LIB.

From bug 28617 comment 6 from Galen:
"""
Time marches on, and one of the motivations for having kohalib.pl - making
it possible to install Koha without setting a single environment variable -
has been obviated by the vast improvements in the ease of installing Koha.

Consequently, I think kohalib.pl can go away.
"""

Test plan:
confirm that the changes make sense and that kohalib.pl can be removed
safely.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
64 files changed:
Makefile.PL
misc/add_date_fields_to_marc_records.pl
misc/batchCompareMARCvsFrameworks.pl
misc/batchDeleteUnusedSubfields.pl
misc/batchImportMARCWithBiblionumbers.pl
misc/batchRebuildBiblioTables.pl
misc/batchRepairMissingBiblionumbers.pl
misc/commit_file.pl
misc/cronjobs/advance_notices.pl
misc/cronjobs/batch_anonymise.pl
misc/cronjobs/build_browser_and_cloud.pl
misc/cronjobs/cart_to_shelf.pl
misc/cronjobs/cleanup_database.pl
misc/cronjobs/delete_records_via_leader.pl
misc/cronjobs/gather_print_notices.pl
misc/cronjobs/holds/auto_unsuspend_holds.pl
misc/cronjobs/holds/build_holds_queue.pl
misc/cronjobs/holds/cancel_expired_holds.pl
misc/cronjobs/holds/cancel_unfilled_holds.pl
misc/cronjobs/holds/holds_reminder.pl
misc/cronjobs/import_webservice_batch.pl
misc/cronjobs/longoverdue.pl
misc/cronjobs/membership_expiry.pl
misc/cronjobs/overdue_notices.pl
misc/cronjobs/patron_emailer.pl
misc/cronjobs/process_message_queue.pl
misc/cronjobs/purge_suggestions.pl
misc/cronjobs/reconcile_balances.pl
misc/cronjobs/runreport.pl
misc/cronjobs/serialsUpdate.pl
misc/cronjobs/staticfines.pl
misc/cronjobs/thirdparty/TalkingTech_itiva_inbound.pl
misc/cronjobs/thirdparty/TalkingTech_itiva_outbound.pl
misc/cronjobs/update_patrons_category.pl
misc/cronjobs/update_totalissues.pl
misc/exportauth.pl
misc/kohalib.pl [deleted file]
misc/link_bibs_to_authorities.pl
misc/load_testing/benchmark_circulation.pl
misc/load_testing/benchmark_staff.pl
misc/maintenance/UNIMARC_fix_collectiontitle.pl
misc/maintenance/UNIMARC_sync_date_created_with_marc_biblio.pl
misc/maintenance/borrowers-force-messaging-defaults.pl
misc/maintenance/fix_accountlines_date.pl
misc/maintenance/fix_accountlines_rmdupfines_bug8253.pl
misc/maintenance/fix_mysql_constraints.pl
misc/maintenance/touch_all_biblios.pl
misc/maintenance/touch_all_items.pl
misc/migration_tools/22_to_30/convert_to_utf8.pl
misc/migration_tools/22_to_30/export_Authorities.pl
misc/migration_tools/22_to_30/export_Authorities_xml.pl
misc/migration_tools/22_to_30/missing090field.pl
misc/migration_tools/22_to_30/move_marc_to_authheader.pl
misc/migration_tools/22_to_30/move_marc_to_biblioitems.pl
misc/migration_tools/22_to_30/rebuild_leader.pl
misc/migration_tools/22_to_30/rebuild_unimarc_100.pl
misc/migration_tools/bulkmarcimport.pl
misc/migration_tools/checkNonIndexedBiblios.pl
misc/migration_tools/create_analytical_rel.pl
misc/migration_tools/import_lexile.pl
misc/migration_tools/switch_marc21_series_info.pl
misc/stage_file.pl
t/db_dependent/00-strict.t
xt/yaml_valid.t