Bug 23013: Upgrade DataTables in the staff client
authorOwen Leonard <oleonard@myacpl.org>
Thu, 6 Jun 2019 16:48:08 +0000 (16:48 +0000)
committerMartin Renvoize <martin.renvoize@ptfs-europe.com>
Thu, 22 Aug 2019 14:23:19 +0000 (15:23 +0100)
commit247dca306407ac9568344a0a37aca3bbcffc2468
treea94fc4b050939c06fc5635936b12d0c49252a62d
parent12f583dd2c580cad046605531c79c1a90bf91436
Bug 23013: Upgrade DataTables in the staff client

This patch upgrades DataTables and makes some style changes to the
default DataTables toolbar style. DataTables assets are now combined and
minified using their download customizer, bundling together these
elements:

 - JSZip 2.5.0
 - pdfmake 0.1.36
 - DataTables 1.10.18
 - Buttons 1.5.6
 - Column visibility 1.5.6
 - HTML5 export 1.5.6
 - Print view 1.5.6
 - FixedHeader 3.1.4

DataTables assets have been moved from lib/jquery/plugins to
lib/datatables. The global header and footer include files are updated
correspondingly.

This patch removes the custom "four_button" pagination configuration and
updates pages which used it to use the built-in "full" type instead.
This is done for the sake of consistency and upgradability. This change
touches a lot of files.

Table-specific CSS has been moved from staff-global.scss to a new
include, _tables.scss. A second common include, _mixins.scss has some
variable definitions used in both files.

Many images have been made obsolete by this change and have been
removed.

To test, apply the patch and regenerate the staff client CSS. View
various pages in the staff client with tables:

 - Not formatted by DataTables:
   - Reports -> Most circulated items
   - Catalog -> Search results
 - Formatted by DataTables without column configuration
   - Acquisitions -> Vendor search
   - Lists
 - Formatted by DataTables with column configuration
   - Administration -> Libraries
   - Administration -> Item types
   - Reports -> Saved SQL reports
 - Non-standard DataTables configurations:
   - Circulation -> Checkouts
   - Administration -> System preferences
   - Reports -> Lost items

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
93 files changed:
koha-tmpl/intranet-tmpl/lib/datatables/datatables.css [new file with mode: 0644]
koha-tmpl/intranet-tmpl/lib/datatables/datatables.js [new file with mode: 0644]
koha-tmpl/intranet-tmpl/lib/datatables/datatables.min.css [new file with mode: 0644]
koha-tmpl/intranet-tmpl/lib/datatables/datatables.min.js [new file with mode: 0644]
koha-tmpl/intranet-tmpl/lib/jquery/plugins/buttons.colVis.min.js [deleted file]
koha-tmpl/intranet-tmpl/lib/jquery/plugins/buttons.html5.min.js [deleted file]
koha-tmpl/intranet-tmpl/lib/jquery/plugins/buttons.print.min.js [deleted file]
koha-tmpl/intranet-tmpl/lib/jquery/plugins/dataTables.buttons.min.js [deleted file]
koha-tmpl/intranet-tmpl/lib/jquery/plugins/jquery.dataTables.min.js [deleted file]
koha-tmpl/intranet-tmpl/prog/css/buttons.dataTables.min.css [deleted file]
koha-tmpl/intranet-tmpl/prog/css/datatables.css [deleted file]
koha-tmpl/intranet-tmpl/prog/css/itemsearchform.css
koha-tmpl/intranet-tmpl/prog/css/src/_mixins.scss [new file with mode: 0644]
koha-tmpl/intranet-tmpl/prog/css/src/_tables.scss [new file with mode: 0644]
koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss
koha-tmpl/intranet-tmpl/prog/en/includes/datatables.inc
koha-tmpl/intranet-tmpl/prog/en/includes/doc-head-close.inc
koha-tmpl/intranet-tmpl/prog/en/includes/mana/mana-report-search-result.inc
koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt
koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basketgroup.tt
koha-tmpl/intranet-tmpl/prog/en/modules/acqui/edifactmsgs.tt
koha-tmpl/intranet-tmpl/prog/en/modules/acqui/histsearch.tt
koha-tmpl/intranet-tmpl/prog/en/modules/acqui/lateorders.tt
koha-tmpl/intranet-tmpl/prog/en/modules/acqui/newordersubscription.tt
koha-tmpl/intranet-tmpl/prog/en/modules/acqui/newordersuggestion.tt
koha-tmpl/intranet-tmpl/prog/en/modules/acqui/ordered.tt
koha-tmpl/intranet-tmpl/prog/en/modules/acqui/parcel.tt
koha-tmpl/intranet-tmpl/prog/en/modules/acqui/spent.tt
koha-tmpl/intranet-tmpl/prog/en/modules/acqui/uncertainprice.tt
koha-tmpl/intranet-tmpl/prog/en/modules/admin/additional-fields.tt
koha-tmpl/intranet-tmpl/prog/en/modules/admin/aqbudgetperiods.tt
koha-tmpl/intranet-tmpl/prog/en/modules/admin/auth_tag_structure.tt
koha-tmpl/intranet-tmpl/prog/en/modules/admin/authorised_values.tt
koha-tmpl/intranet-tmpl/prog/en/modules/admin/authtypes.tt
koha-tmpl/intranet-tmpl/prog/en/modules/admin/branches.tt
koha-tmpl/intranet-tmpl/prog/en/modules/admin/itemtypes.tt
koha-tmpl/intranet-tmpl/prog/en/modules/admin/marctagstructure.tt
koha-tmpl/intranet-tmpl/prog/en/modules/admin/overdrive.tt
koha-tmpl/intranet-tmpl/prog/en/modules/admin/printers.tt
koha-tmpl/intranet-tmpl/prog/en/modules/admin/z3950servers.tt
koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/additem.tt
koha-tmpl/intranet-tmpl/prog/en/modules/circ/checkout-notes.tt
koha-tmpl/intranet-tmpl/prog/en/modules/circ/on-site_checkouts.tt
koha-tmpl/intranet-tmpl/prog/en/modules/circ/overdue.tt
koha-tmpl/intranet-tmpl/prog/en/modules/circ/reserveratios.tt
koha-tmpl/intranet-tmpl/prog/en/modules/circ/waitingreserves.tt
koha-tmpl/intranet-tmpl/prog/en/modules/clubs/club-enrollments.tt
koha-tmpl/intranet-tmpl/prog/en/modules/clubs/clubs.tt
koha-tmpl/intranet-tmpl/prog/en/modules/course_reserves/course-details.tt
koha-tmpl/intranet-tmpl/prog/en/modules/course_reserves/course-reserves.tt
koha-tmpl/intranet-tmpl/prog/en/modules/labels/label-edit-batch.tt
koha-tmpl/intranet-tmpl/prog/en/modules/labels/label-manage.tt
koha-tmpl/intranet-tmpl/prog/en/modules/members/boraccount.tt
koha-tmpl/intranet-tmpl/prog/en/modules/members/holdshistory.tt
koha-tmpl/intranet-tmpl/prog/en/modules/members/notices.tt
koha-tmpl/intranet-tmpl/prog/en/modules/members/readingrec.tt
koha-tmpl/intranet-tmpl/prog/en/modules/patron_lists/list.tt
koha-tmpl/intranet-tmpl/prog/en/modules/patron_lists/lists.tt
koha-tmpl/intranet-tmpl/prog/en/modules/patroncards/edit-batch.tt
koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt
koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-search.tt
koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-add.tt
koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-numberpatterns.tt
koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt
koha-tmpl/intranet-tmpl/prog/en/modules/tags/list.tt
koha-tmpl/intranet-tmpl/prog/en/modules/tools/upload.tt
koha-tmpl/intranet-tmpl/prog/img/asc.gif [deleted file]
koha-tmpl/intranet-tmpl/prog/img/ascdesc.gif [deleted file]
koha-tmpl/intranet-tmpl/prog/img/datatables/back_disabled.jpg [deleted file]
koha-tmpl/intranet-tmpl/prog/img/datatables/back_enabled.jpg [deleted file]
koha-tmpl/intranet-tmpl/prog/img/datatables/forward_disabled.jpg [deleted file]
koha-tmpl/intranet-tmpl/prog/img/datatables/forward_enabled.jpg [deleted file]
koha-tmpl/intranet-tmpl/prog/img/datatables/sort_asc.png [deleted file]
koha-tmpl/intranet-tmpl/prog/img/datatables/sort_asc_disabled.png [deleted file]
koha-tmpl/intranet-tmpl/prog/img/datatables/sort_both.png [deleted file]
koha-tmpl/intranet-tmpl/prog/img/datatables/sort_desc.png [deleted file]
koha-tmpl/intranet-tmpl/prog/img/datatables/sort_desc_disabled.png [deleted file]
koha-tmpl/intranet-tmpl/prog/img/first-disabled.png [deleted file]
koha-tmpl/intranet-tmpl/prog/img/first.png [deleted file]
koha-tmpl/intranet-tmpl/prog/img/last-disabled.png [deleted file]
koha-tmpl/intranet-tmpl/prog/img/last.png [deleted file]
koha-tmpl/intranet-tmpl/prog/img/next-disabled.png [deleted file]
koha-tmpl/intranet-tmpl/prog/img/next.png [deleted file]
koha-tmpl/intranet-tmpl/prog/img/prev-disabled.png [deleted file]
koha-tmpl/intranet-tmpl/prog/img/prev.png [deleted file]
koha-tmpl/intranet-tmpl/prog/js/addorderiso2709.js
koha-tmpl/intranet-tmpl/prog/js/biblio_framework.js
koha-tmpl/intranet-tmpl/prog/js/categories.js
koha-tmpl/intranet-tmpl/prog/js/datatables.js
koha-tmpl/intranet-tmpl/prog/js/pages/stockrotation.js
koha-tmpl/intranet-tmpl/prog/js/pages/tags-review.js
koha-tmpl/intranet-tmpl/prog/js/rotating-collections.js
koha-tmpl/intranet-tmpl/prog/js/subscription-add.js