Bug 26231: Remove incorrect use of AddAuthority() when 001 present
authorDavid Cook <dcook@prosentient.com.au>
Tue, 18 Aug 2020 02:20:32 +0000 (12:20 +1000)
committerLucas Gass <lucas@bywatersolutions.com>
Fri, 16 Oct 2020 16:09:13 +0000 (16:09 +0000)
commit276602aadbdb27cbec780c9564b93ccd0c1961b6
treef820d7b66976226678836093125ae2f020256b22
parent0fc15fdb7105a49a35f157c7b690b571aa8646cd
Bug 26231: Remove incorrect use of AddAuthority() when 001 present

This patch removes the use of AddAuthority with a non-empty
authid argument, since that triggers an update rather than an insert.

In practice, the update also fails, but the error isn't raised,
as the database connection doesn't have RaiseError set.

Test plan:
1) Do not apply patch
2) Try to bulkmarcimport an authority file with a 001
3) Observe that the script reports success but no authority is added
4) Apply the path
5) Try to bulkmarcimport an authority file with a 001
6) Observe that the script reports success and the authority is added

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
(cherry picked from commit 9622561636387ced932cc31e285d13cdba607c47)

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
misc/migration_tools/bulkmarcimport.pl