Bug 10028: fix how ModReceiveOrder() calls NewOrder()
authorJonathan Druart <jonathan.druart@biblibre.com>
Thu, 11 Apr 2013 10:00:45 +0000 (12:00 +0200)
committerGalen Charlton <gmc@esilibrary.com>
Fri, 16 Aug 2013 16:57:52 +0000 (16:57 +0000)
commit29689de399a8927547c36e53461c7766ecc604f0
tree5adf6784a85438c087eecba8f800c2e1c79a546e
parentb0ea3be36c8e7ae6dc6f28820b1c26fc909d9039
Bug 10028: fix how ModReceiveOrder() calls NewOrder()

In C4::Acquisition::ModReceiveOrder, a call to NewOrder is badly used.

NewOrder returns ($basketno, $ordernumber) but in ModReceiveOrder the
ordernumber is got with
  my $ordernumber = NewOrder( $args );

It works because:
sub t{
    return ("a", "b");
}
my $a = t();
say $a;

Will display 'b'.

But it is not really clear.

Test plan:
Check that there is no regression for partial receives.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
C4/Acquisition.pm