Bug 30108: Allow making hold dates required
authorMarcel de Rooy <m.de.rooy@rijksmuseum.nl>
Tue, 15 Feb 2022 15:25:59 +0000 (16:25 +0100)
committerFridolin Somers <fridolin.somers@biblibre.com>
Mon, 2 May 2022 21:22:58 +0000 (11:22 -1000)
commit305cd0036dd5a669f82f3c88a0402778f8e26f43
treeb575d60fb6c30a32e62f1b8ca4147d1b4499380c
parent85a67cb6d2c233b37bca18351cce4c4d52467c85
Bug 30108: Allow making hold dates required

Side note: Template still referred to class holddateto while not
being used any longer. Replaced this occurrence by futuredate.

Test plan:
[1] Disable OPACAllowHoldDateInFuture.
[2] Set pref OPACMandatoryHoldDates to "end date".
[3] Verify that the end date is mandatory on opac-reserve.
[4] Set pref OPACMandatoryHoldDates to "start date".
[5] Verify that no dates are required.
[6] Enable OPACAllowHoldDateInFuture.
[7] Verify that start dates are required.
[8] Set pref OPACMandatoryHoldDates to "no dates".
[9] Verify that no dates are required again.

Bonus:
Check that more options box is opened when a date still is required.
In case of item level being forced, verify that more options is opened
regardless of pref setting.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-reserve.tt