Bug 14337: AllowRenewalIfOtherItemsAvailable counts holdable not for loan items when...
authorKyle M Hall <kyle@bywatersolutions.com>
Fri, 5 Jun 2015 11:50:26 +0000 (07:50 -0400)
committerTomas Cohen Arazi <tomascohen@theke.io>
Fri, 28 Aug 2015 13:42:25 +0000 (10:42 -0300)
commit3389e03035dc6b187045e279dc34916b005afbfb
tree78d8167875db43bfa98a9c8efbe69c97a86bd749
parent991a8181b29c2fec4fe50b45328a27c78a60f3c4
Bug 14337: AllowRenewalIfOtherItemsAvailable counts holdable not for loan items when checking renewability

AllowRenewalIfOtherItemsAvailable checks
C4::Reserves::IsAvailableForItemLevelRequest to see if the item is
holdable, which catches not for loan values less than 0 ( i.e. holdable,
but not circ-able ). However, since this feature is about
actually checking out items to patrons, we should not count *any* not
for loan items when deciding if the available items will satisfy all
current holds.

Test Plan:
 1) Enable AllowRenewalIfOtherItemsAvailable
 2) Create a record with two items
 3) Check out one item to a patron
 4) Ensure the item is renewable
 5) Place a hold on the record
 6) The item should now be non-renewable
 7) Add a second item to the record, but with a not for loan value < 0
 8) Note the checkout is still renewable
 9) Apply this patch
10) Note the checkout is now non-renewable

Works ok.

Signed-off-by: Amit Gupta <amit.gupta@informaticsglobal.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
C4/Circulation.pm