Bug 10317: improve display when order receiving page is given an invalid invoiceid
authorJonathan Druart <jonathan.druart@biblibre.com>
Thu, 23 May 2013 14:42:38 +0000 (16:42 +0200)
committerTomas Cohen Arazi <tomascohen@gmail.com>
Sat, 6 Jul 2013 23:55:01 +0000 (20:55 -0300)
commit3446a86f80313316c5f939e10b983c8703095030
tree94ff611d733a6d68041431cd84fa9913ad507f1a
parent32de75b948944debe41380293c58cfe02bcbcc2d
Bug 10317: improve display when order receiving page is given an invalid invoiceid

This patch fixes some things on the order receiving/parcel page.

1/ Removes dead code
2/ Displays an error message if invoiceid is unset or does not refer to an
invoice
3/ Fixes a bug in the note ("change note" and "add note" links)

Test plan:
1/ Try to call the invoice page with an existing invoiceid and check
that order results are consistent.
2/ Try without invoiceid or a bad invoiceid and check that an error
message is displayed.
3/ Add and change notes.

Signed-off-by: Cedric Vita <cedric.vita@dracenie.com>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Works nicely for all tests done.
- parcel.pl with invalid invoicenumber gives a nice error message
- parcel.pl with a valid invoicenumber looks normal
- changing and editing order notes works well

Passes QA script.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
(cherry picked from commit d932f6ff250c3a50db379b23abfc40a77620e94b)

Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
acqui/parcel.pl
koha-tmpl/intranet-tmpl/prog/en/modules/acqui/parcel.tt