Bug 24892: Resolve uninitialized warns from opac-memberentry
authorMarcel de Rooy <m.de.rooy@rijksmuseum.nl>
Wed, 18 Mar 2020 13:54:52 +0000 (13:54 +0000)
committerMartin Renvoize <martin.renvoize@ptfs-europe.com>
Fri, 20 Mar 2020 15:40:43 +0000 (15:40 +0000)
commit3944f20beb6850f576cb9f68cd5ee9ac4493efb5
treed62a18875d734c2e7fd0c9f88dc90e8136ea6055
parent4c66b9c874f81f9c73648da5da6b7c8732a62221
Bug 24892: Resolve uninitialized warns from opac-memberentry

Especially line 500 (current master).

Use of uninitialized value $new_data{"sort2"} in string eq at /usr/share/koha/opac/opac-memberentry.pl line 500.
Use of uninitialized value in string eq at /usr/share/koha/opac/opac-memberentry.pl line 500.

Simple fix, not completely trivial due to adding xor ;)

Test plan:
Do not apply, update from opac memberentry. Check warns in log.
Apply patch, update again. Less warns?

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
opac/opac-memberentry.pl