Bug 26948: Remove double encoding from sent emails
authorJoonas Kylmälä <joonas.kylmala@helsinki.fi>
Fri, 6 Nov 2020 11:35:39 +0000 (13:35 +0200)
committerJonathan Druart <jonathan.druart@bugs.koha-community.org>
Thu, 12 Nov 2020 16:09:52 +0000 (17:09 +0100)
commit4415fdb0f4785dff24c9773f85a9b32885c385ac
tree7682620e8d5d2178001620ebeef27d7caa43ff62
parentfbd0bbf98f574a7eb804673978a198eea6fdd798
Bug 26948: Remove double encoding from sent emails

The sent emails from Koha were garbled / double encoded because
Koha::Email now after the refactoring and moving to use Email::Stuffer
handles the encoding itself. Previously the Koha::Email callee had to
handle the encoding. This patch removes the double encoding in the
email subject and content.

To test:
 1) Put some UTF-8 characters like ä in the HOLD template subject and body
 2) Create hold and check-in an item to make it Waiting and cause the
 email to be send
 3) Notice the email comes garbled / double encoded
 4) Apply patch
 5) Repeat step 2) and notice the email comes without any issues in
    encoding and look OK.
 6) Make sure "prove t/Koha/Email.t" and "prove
    t/db_dependent/Letters.t" and passes

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
C4/Letters.pm