Bug 9860 [Alternate] Incorrect box heading 'Cannot check in' when a late document...
authorOwen Leonard <oleonard@myacpl.org>
Mon, 8 Apr 2013 14:13:11 +0000 (10:13 -0400)
committerChris Cormack <chris@bigballofwax.co.nz>
Sat, 27 Apr 2013 05:36:32 +0000 (17:36 +1200)
commit49e363a4c571a22eb487082f5f1dbda01321525f
tree7ae1e30b7fea1c78fc110785d5fc0abd3f89995e
parent74b4355cfda5008578e9b787e8f37171c4b28526
Bug 9860 [Alternate] Incorrect box heading 'Cannot check in' when a late document is returned

The fix for Bug 9397 moved the "cannot check in" heading from within the
one conditional where it should have been displayed to the top of all
check-in errors/messages. "Cannot check in" is still only valid if the
item is withdrawn and BlockReturnOfWithdrawnItems is ON.

In order to accomplish the goal of Bug 9397 while fixing Bug 9860 this
patch puts "cannot check in" back into the correct conditional and adds
a generic heading to check in messages for accessibility purposes.

To test, check in items which will trigger a variety of errors
including:

- item must be returned to home library
- item is lost
- item is withdrawn (wtih BlockReturnOfWithdrawnItems on and off)
- item is overdue

...as well as items which should check in normally. Messages should
display correctly.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt