Bug 14201: Plugin marc21_leader_book is useless
authorMarcel de Rooy <m.de.rooy@rijksmuseum.nl>
Tue, 14 Jul 2015 15:26:55 +0000 (17:26 +0200)
committerTomas Cohen Arazi <tomascohen@unc.edu.ar>
Mon, 28 Sep 2015 15:19:52 +0000 (12:19 -0300)
commit4c2e4cd0abac7e647b90695e5c4782b6a89bfe70
tree5aa2ea604b9b6ef4d7e10091899d6d41e60e8380
parent6a5ca69bca091869773863b4436b78f3956589ec
Bug 14201: Plugin marc21_leader_book is useless

A closer look at this plugin revealed the following:
[1] The leader_book builder redirects to leader.pl; the launcher code with
    leader_book.tt is dead.
[2] A diff of the two templates showed that most changes are minimal and
    irrelevant. Some updates to leader have not been incorporated into
    the unused leader_book.
[3] Leader_book does not use Focus while leader does.

This patch removes all traces of leader_book :)
It includes a tiny db revision for those brave people using it. The only
behavior change for them is the focus change.
Another small change: we do not need Search.pm in marc21_leader.

Test plan:
[1] Run the db revision. If you had some field attached to leader_book,
    it should be gone.
[2] Check if the leader plugin still works as expected.
[3] Run the FrameworkPlugin unit test. Ignore warnings from field_007.
[4] Git grep on marc21_leader_book. You will only find references to
    PO files in misc/translator.

Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen@unc.edu.ar>
cataloguing/value_builder/marc21_leader.pl
cataloguing/value_builder/marc21_leader_book.pl [deleted file]
installer/data/mysql/atomicupdate/14201_marc21_leader_book.sql [new file with mode: 0644]
koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/marc21_leader_book.tt [deleted file]