Bug 23012: (QA follow-up) Combine method to get both values
authorNick Clemens <nick@bywatersolutions.com>
Mon, 24 Oct 2022 11:13:32 +0000 (11:13 +0000)
committerTomas Cohen Arazi <tomascohen@theke.io>
Mon, 24 Oct 2022 20:43:29 +0000 (17:43 -0300)
commit4d994773f83468b561896939f16131d0332d9cfc
treee439e7d1efb80303daa499cdbea7eae211abc7fc
parentd4556b786d12f5a8c70289181024056979707d93
Bug 23012: (QA follow-up) Combine method to get both values

The code for get_processingreturn_policy was very similar to
get_lostreturn_policy. Combining the two methods allows for use of
get_effective_rules which uses get_effective_rule_value which is cached.
This should reduce lines of code and improve performance

Tests updated and adjusted as well

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Koha/CirculationRules.pm
Koha/Item.pm
t/db_dependent/Koha/CirculationRules.t