Bug 18300: [QA Follow-up] Fix return value inconsistency
authorMarcel de Rooy <m.de.rooy@rijksmuseum.nl>
Mon, 3 Apr 2017 19:43:48 +0000 (21:43 +0200)
committerKyle M Hall <kyle@bywatersolutions.com>
Fri, 21 Apr 2017 00:11:40 +0000 (00:11 +0000)
commit4eb53eeee9dbf1c4c3a4c6da48148e0a0d27f0fe
treec6360c9785aa0feccdfefe81f384fd8875ca45c4
parent8c80c9b8e127145e638963eb0eaa8fdb420ff4cd
Bug 18300: [QA Follow-up] Fix return value inconsistency

As noted on bug report 17669, the return values of delete (both singular
and plural), delete_missing and delete_temporary should be consistent.

Removed the if-construction around full_path. We do not need it; in the
very exceptional case that full_path would be empty, we should delete
the record since the file is missing.

Adjusted POD and unit tests accordingly.

Test plan:
Run t/db_dependent/Upload.t

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Koha/UploadedFiles.pm
t/db_dependent/Upload.t