Bug 27586: Import patrons script has a confirm switch that doesn't nothing!
authorKyle M Hall <kyle@bywatersolutions.com>
Mon, 1 Feb 2021 18:22:58 +0000 (13:22 -0500)
committerVictor Grousset/tuxayo <victor@tuxayo.net>
Sun, 21 Feb 2021 15:18:24 +0000 (16:18 +0100)
commit534853fcab038d924eeca9a4d79f8598a745b548
tree37381b57d8f5c4e7262911ab1e2a14dd3de39a60
parent52135ea553c9fcf02cb41490a1a790f31ed7ed15
Bug 27586: Import patrons script has a confirm switch that doesn't nothing!

If the script misc/import_patrons.pl is run without "--confirm" it reports
that it is "running in dry-run mode" but it is not!

Test Plan:
1) Import a CSV of patrons using import_patrons.pm *without* the --confirm parameter
2) Note that it does actually import the patrons
3) Apply this patch
4) Note that this time the patrons are not actually imported
5) Import again with --confirm
6) Note that the patrons were actually imported this time!

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
(cherry picked from commit d3005a2a4c493c624ffd6204f6fccc83ea350361)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
(cherry picked from commit 19e0b91e12b520387938bb9c20bd605b757d3211)

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
(cherry picked from commit c0a7f53a62b6c90c87234288fc0cee910a7f6bd0)
Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>
Koha/Patrons/Import.pm
misc/import_patrons.pl