Bug 19003: Add a TestBuilder default for borrowers.login_attempts
authorMarcel de Rooy <m.de.rooy@rijksmuseum.nl>
Sat, 29 Jul 2017 15:06:52 +0000 (17:06 +0200)
committerJonathan Druart <jonathan.druart@bugs.koha-community.org>
Tue, 8 Aug 2017 12:39:04 +0000 (09:39 -0300)
commit5bb56bf336187cde38e1a3b89c792ee6dc231acf
treebc67d3707cc401acca6522839f4ebb5cbff0f1e0
parent0853c4e2b4366a235077a24a873fc81a754afecb
Bug 19003: Add a TestBuilder default for borrowers.login_attempts

Bug 18314 causes t/db/SIP/Message.t to fail (quite often) since
TestBuilder fills login_attempts with a random number. (Note: Only
when FailedLoginAttempts is non-zero.)
Trivial fix: TestBuilder should have a zero default for login_attempts.

Test plan:
Do not yet apply this patch.
Set pref FailedLoginAttempts to say 3.
Run t/db_dependent/SIP/Message.t. Might fail on the password test (CQ).
Apply this patch.
Run t/db_dependent/SIP/Message.t again. Does not fail anymore.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
t/lib/TestBuilder.pm