Bug 23376: Clean up order receipt page code
authorNick Clemens <nick@bywatersolutions.com>
Thu, 25 Jul 2019 19:52:25 +0000 (19:52 +0000)
committerJonathan Druart <jonathan.druart@bugs.koha-community.org>
Thu, 8 Oct 2020 14:03:40 +0000 (16:03 +0200)
commit5d4740dfb02bbf4305f66045fc0a01182c717873
tree83bc7cace56966b9eb5e8267088f6004a5f4a7bd
parentd7c58c10f100a80393c42a62c7c1ecce713c817c
Bug 23376: Clean up order receipt page code

This patchset switches from using DB lookups to using an order object for most things on orderreceive.pl

It simplifies the script and makes minimal changes to the template

To test:
1 - Place some orders and receive them
2 - Have orders with or without subscriptions attached
3 - Try with different AcqCreateItems settings
4 - Apply patch
5 - No behaviour should change
6 - Read code to ensure things make sense

Signed-off-by: Agustin Moyano <agustinmoyano@theke.io>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
acqui/orderreceive.pl
koha-tmpl/intranet-tmpl/prog/en/modules/acqui/orderreceive.tt