Bug 27064: (QA follow-up) Pass 'replace' through to Koha::Item::Transfer->cancel
authorMartin Renvoize <martin.renvoize@ptfs-europe.com>
Thu, 6 May 2021 15:31:39 +0000 (16:31 +0100)
committerJonathan Druart <jonathan.druart@bugs.koha-community.org>
Mon, 14 Jun 2021 14:10:15 +0000 (16:10 +0200)
commit630468bf08d9ebb62c9e07fb7de85824b64aef42
treeac2ec0a115b13f4c295a75cf0c32bc06ee3978dc
parent6ac4542948c451595a154a5467e548a43e9817e8
Bug 27064: (QA follow-up) Pass 'replace' through to Koha::Item::Transfer->cancel

The `replace` option found in Koha::Item->request_transfer should be
passed through to Koha::Item::Transfer->cancel and prevent any reverse
transfers from being queued in such cases.

This prevents modItemTransfer from adding superflous reverse transfers
whenever it is used.

Test plan
1/ Run t/db_dependent/Koha/Item.t to prove the new tests pass

Signed-off-by: Joonas Kylmälä <joonas.kylmala@helsinki.fi>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Koha/Item.pm
Koha/Item/Transfer.pm
t/db_dependent/Koha/Item.t