Bug 20144: [sql_modes] Fix GROUP BY clause in GetLetters
authorJonathan Druart <jonathan.druart@bugs.koha-community.org>
Mon, 5 Feb 2018 21:26:05 +0000 (18:26 -0300)
committerJonathan Druart <jonathan.druart@bugs.koha-community.org>
Tue, 13 Feb 2018 16:58:54 +0000 (13:58 -0300)
commit666cbed5e17f8b644300c43091231554eaeb3eb0
tree5a38880b21adecd9194c701bee4939e41210207a
parent2decad7b43e298524c0aea812462b73c7f088573
Bug 20144: [sql_modes] Fix GROUP BY clause in GetLetters

This subroutine is wrong and must be rewritten using
Koha::Notice::Templates.
Mainly because the DB structure is bad.
Meanwhile we remove the branchcode from the SELECT to get correct
results, it was not used by callers anyway.

Fix for:
'koha_kohadev.letter.module' isn't in GROUP BY

t/db_dependent/Letters.t

Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
C4/Letters.pm
t/db_dependent/Letters.t
t/db_dependent/Letters/GetLettersAvailableForALibrary.t