]> git.koha-community.org Git - koha.git/commit
Bug 2539. Remove unintegrated "spsuggest" code from search scripts.
authorJoe Atzberger <joe.atzberger@liblime.com>
Thu, 2 Jul 2009 03:47:35 +0000 (22:47 -0500)
committerHenri-Damien LAURENT <henridamien.laurent@biblibre.com>
Wed, 16 Sep 2009 21:19:41 +0000 (23:19 +0200)
commit6a02281f7d3ac894870b150ebc475b812efcf2d1
tree0c66ba73b7eab4d881503302fe113d41fcb1d2c7
parent361bbdf3a494ac0d930034c623189ddc3ce70bcd
Bug 2539. Remove unintegrated "spsuggest" code from search scripts.

The intent of kohaspsuggest is very confused.  It wanted to simultaneously
log every search query, and get spelling suggestions from a totally different
database_host:db_user:db_password:database.  The implementation seems
never have really made it into 3.0, however, since the only trace of the
tables it wants to query are in misc/migration_tools/22_to_30/phrase_log.sql

The job misc/spellcheck_suggest/make_spellcheck_suggest.pl does not even
target the same remote DB as the syspref tells the search code to do.  Instead, it hits the
local DB and, not finding the tables that have no way of existing in a 3.0
install, it CREATES its own tables spontaneously, using MyISAM storage, no less.
This script should be drastically overhauled, or more likely just removed.

Other fixes:
Commented out unconditional warn!
Also reduced bizarre whitespace amounts in catalogue/search.pl and
fixed warning as recommended by perl -wc:
    Scalar value @newresults[0] better written as $newresults[0]

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
catalogue/search.pl
opac/opac-search.pl