Bug 8367: Add holds_pickup_period circulation rule
authorAleisha Amohia <aleishaamohia@hotmail.com>
Mon, 20 Apr 2020 16:13:35 +0000 (16:13 +0000)
committerTomas Cohen Arazi <tomascohen@theke.io>
Wed, 1 Nov 2023 21:01:30 +0000 (18:01 -0300)
commit6c0eb32a084c50efc7af16720820e355ceb8a4bf
tree3ceed32b43589c0e1820d4ad0a576c611caf1ecd
parentc100eda1bd4c6fa4fb46c95b70efef3bbe4c75a2
Bug 8367: Add holds_pickup_period circulation rule

So that pickup delay can have a different value per patron category,
   item type or branch.

To test:

1) Update database, restart services
2) Set ReservesMaxPickUpDelay syspref (if not already set)
3) Edit your circulation rules and set a value under 'Holds pickup
period (day) that is DIFFERENT from ReservesMaxPickUpDelay. Set a few
different numbers for different branches as well.
4) Place a hold on a biblio from the staff client.
5) Check in an item from that biblio and confirm the hold as waiting
6) Confirm the expiration date is calculated using the 'Holds pickup
period' value instead of the ReservesMaxPickUpDelay syspref
7) Revert the waiting status and delete the hold
8) Re-place the hold on the biblio on the OPAC. Notice that when you
change the pick up location, the number of days in the pickup message
below the dropdown changes based on the circ rules.
9) Create a holiday with a date that will overlap with the 'Holds pickup
period'
10) Check in an item from that biblio and confirm the hold as waiting
11) Confirm the expiration date is calculated using the 'Holds pickup
period' value AND considers the special holiday
12) Confirm tests pass t/db_dependent/Holds/WaitingReserves.t
13) Test Talking Tech:
13a) Enable TalkingTechItivaPhoneNotification
13b) Go to Tools -> Notices & slips. Add content to the HOLD phone
(itiva) notice.
13c) In your terminal, run perl
/path/to/koha/misc/cronjobs/thirdparty/TalkingTech_itiva_outbound.pl -o
~/itiva.tmp -w 0 --type=RESERVE

Sponsored-by: Catalyst IT
Signed-off-by: Emmi Takkinen <emmi.takkinen@koha-suomi.fi>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Kelly <kelly@bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Kelly <kelly@bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Koha/CirculationRules.pm
Koha/Hold.pm
admin/smart-rules.pl
installer/data/mysql/atomicupdate/bug_8367-add_holds_pickup_period_circrule.perl [new file with mode: 0644]
installer/onboarding.pl
koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt
koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-reserve.tt
misc/cronjobs/thirdparty/TalkingTech_itiva_outbound.pl
opac/opac-reserve.pl
t/db_dependent/Holds/WaitingReserves.t