Bug 30213: Hide Delete (aka Priority) column when user only has place_hold permission
authorOwen Leonard <oleonard@myacpl.org>
Thu, 3 Mar 2022 12:34:33 +0000 (12:34 +0000)
committerTomas Cohen Arazi <tomascohen@theke.io>
Mon, 8 Aug 2022 16:29:47 +0000 (13:29 -0300)
commit6eaf23d2d4691844a75db1aaf3090d9eb9747a33
tree5d928fc89e9c50d177059f716dcec85a4f1416f0
parentaca26a83e367ae930eeb22241ef3af7b4244d127
Bug 30213: Hide Delete (aka Priority) column when user only has place_hold permission

This patch changes the way the priority column displays when viewing a
list of holds as a user who doesn't have permission to change hold
priority.

To test:

- Apply the patch and log into the staff interface as a user with
  at least "place_hold" permission.
- Locate a record which can be put on hold and place multiple holds.
- View the list of holds.
- As a user with both "place_hold" and "modify_holds_priority"
  permission, you should see a "Priority" column with <select> fields
  allowing you to change hold priority. You should also see the arrow
  buttons for changing priority.
- As a user with only "place_hold" permission, the "Priority" column
  should show the priority as a number. You should not see the arrow
  buttons.
- In both cases, confirm that all operations work correctly: Changing
  hold date, expiration date, pickup library, suspended status;
  Cancelling holds.

Signed-off-by: Christopher Brannon <cbrannon@cdalibrary.org>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
koha-tmpl/intranet-tmpl/prog/en/includes/holds_table.inc