Bug 15407: Koha::Patron::Categories - replace C4::Category->all
authorJonathan Druart <jonathan.druart@bugs.koha-community.org>
Mon, 21 Dec 2015 17:04:30 +0000 (17:04 +0000)
committerKyle M Hall <kyle@bywatersolutions.com>
Thu, 8 Sep 2016 13:29:03 +0000 (13:29 +0000)
commit6ee8dd3a597d08ccc5122473e55790d3f21d5163
treeff264a0d179a61e4ef0324222f245327c3bcfdaf
parent3bb1578354e75ae160830a410340c6fbb9faaf3a
Bug 15407: Koha::Patron::Categories - replace C4::Category->all

The C4::Category module contained only 1 method to return the patron
categories available for the logged in user.
The new method Koha::Patron::Categories->search_limited does exactly the
same thing (see tests) and must be used in place of it.

Test plan:
- Same prerequisite as before
For the following pages, you should not see patron categories limited to
other libraries.
- On the 'Item circulation alerts' admin page
  (admin/item_circulation_alerts.pl), modify the settings for check-in
  and checkout (NOTE: Should not we display all patron categories on
  this page? If yes, it must be done in another bug report to ease
  backporting it).
- Search for patrons in the admin (budget) and acquisition (order) module.
- On the patron home page (search form in the header)

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
31 files changed:
C4/Category.pm [deleted file]
C4/ItemCirculationAlertPreference.pm
Koha/Patron/Categories.pm
Koha/Template/Plugin/Categories.pm
acqui/add_user_search.pl
admin/add_user_search.pl
admin/item_circulation_alerts.pl
debian/templates/plack.psgi
koha-tmpl/intranet-tmpl/prog/en/includes/patron-search.inc
koha-tmpl/intranet-tmpl/prog/en/modules/members/member.tt
members/guarantor_search.pl
members/member.pl
members/members-home.pl
members/members-update-do.pl
members/members-update.pl
members/nl-search.pl
misc/plack/koha.psgi
patroncards/add_user_search.pl
reports/reserves_stats.pl
serials/add_user_search.pl
t/db_dependent/Category.t [deleted file]
t/db_dependent/Circulation/CheckIfIssuedToPatron.t
t/db_dependent/Circulation/GetIssues.t
t/db_dependent/Koha/Patron/Categories.t
t/db_dependent/Members/GetAllIssues.t
t/db_dependent/Members/GetOverdues.t
t/db_dependent/Members/GetPendingIssues.t
t/db_dependent/Members/IssueSlip.t
t/db_dependent/Ratings.t
t/db_dependent/Utils/Datatables_Members.t
t/db_dependent/Utils/Datatables_Virtualshelves.t