Bug 29180: Rename syspref RequestOnOpac with OPACHoldRequests
authorJonathan Druart <jonathan.druart@bugs.koha-community.org>
Thu, 4 Nov 2021 13:39:28 +0000 (14:39 +0100)
committerJonathan Druart <jonathan.druart@bugs.koha-community.org>
Fri, 5 Nov 2021 11:13:25 +0000 (12:13 +0100)
commit70485bf1cc6848b47797a4035be0689c598e456a
tree65956159e4801cfc6eba79d3a72930d14d005cd7
parent71aa651b5ce696d0a5b37048866d8feaa1119540
Bug 29180: Rename syspref RequestOnOpac with OPACHoldRequests

It is a confusing name because we have 'Article Request' as a feature,
and this does not follow Koha terminology.

Test plan:
`updatedatabase` and confirm that the syspref has been renamed
`git grep RequestOnOpac` => No occurrence in the code

QA: The syspref's value is always retrieved using Koha.Preference from
.tt files, we don't need to send it from controllers or C4::Auth

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
20 files changed:
C4/Auth.pm
C4/UsageStats.pm
installer/data/mysql/atomicupdate/bug_29180.pl [new file with mode: 0755]
installer/data/mysql/mandatory/sysprefs.sql
installer/data/mysql/update22to30.pl
installer/html-template-to-template-toolkit.pl
koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref
koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-detail-sidebar.inc
koha-tmpl/opac-tmpl/bootstrap/en/includes/title-actions-menu.inc
koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-basket.tt
koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-opensearch.tt
koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt
koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-sendbasketform.tt
koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-sendshelfform.tt
koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt
koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-topissues.tt
opac/opac-ISBDdetail.pl
opac/opac-MARCdetail.pl
opac/opac-detail.pl
opac/opac-reserve.pl