Bug 8753 - Smartmatch substitute, Math::Random::Secure, Perltidy, Passwordrecovery.t
authorCharles Farmer <charles.farmer@inlibro.com>
Wed, 30 Sep 2015 14:03:05 +0000 (10:03 -0400)
committerBrendan A Gallagher <brendan@bywatersolutions.com>
Wed, 27 Jan 2016 06:40:54 +0000 (06:40 +0000)
commit76d1509838cb14dbdcaaa8ec495ebe72fb5db34e
tree76f1815e60512b5604a363f21876dd1f09829571
parent70898717c19676f7568b7c7c1cb5e1d250e3b38d
Bug 8753 - Smartmatch substitute, Math::Random::Secure, Perltidy, Passwordrecovery.t

This is a collection of changes taken from different comments (but mostly comment 21 and comment 122).

Passes qa and prove, on my machine at least.

There's also a new test file, Passwordrecovery.t, which covers every method of C4::Passwordrecovery.

To test:

All normal checks plus :

    1/ Receive the email
    2/ Click on the link
    3/ Change the pwd
    4/ Click again on the link
    5/ You should immediately get an error message

Problems with Math/Random/Secure.pm, is solved in following patch, signing off
Signed-off-by: Marc Veron <veron@veron.ch>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
C4/Passwordrecovery.pm
Koha/Schema/Result/BorrowerPasswordRecovery.pm
opac/opac-password-recovery.pl
t/db_dependent/Passwordrecovery.t [new file with mode: 0755]