Bug 17364: Add ability to exclude some columns from selection for system preferences
authorNick Clemens <nick@bywatersolutions.com>
Fri, 6 Nov 2020 11:17:56 +0000 (11:17 +0000)
committerFridolin Somers <fridolin.somers@biblibre.com>
Fri, 5 Feb 2021 15:43:03 +0000 (16:43 +0100)
commit76f800f740ae796062cbdbaf2717eb35af75b1df
tree845e954f9fe461b3e8d5605ddb376a7c66ce752d
parent0ebfff111dcecca92deffb36fd62e58e0a9e3bba
Bug 17364: Add ability to exclude some columns from selection for system preferences

Bug 22844 Added the option to provide a modal for selecting database columns for system preferences

Some system preferences are limited to a subset of the columns allowed. For instance, setting branchcode
in BorrowerUnwantedFields prevents adding new patrons

This patch allows for defining exclusions in the .pref file

To test:
1 - Alter BorroweUnwantedFields and select branchcode
2 - Attempt to add a new patron
3 - Get a message like "Something went wrong. Check the logs"
4 - Apply patches
5 - Alter the preference again
6 - Note that branchcode is unchecked and disabled
7 - Save the pref
8 - Add a patron
9 - It succeeds

Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Bug 17364: (follow-up) Add missing filter

Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
(cherry picked from commit b986a8419b2012565e5bf2d4f942b06901c7ad74)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
admin/preferences.pl
koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences.tt
koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/patrons.pref
koha-tmpl/intranet-tmpl/prog/js/pages/preferences.js