Bug 14821: Do not list not returned items
authorJonathan Druart <jonathan.druart@bugs.koha-community.org>
Tue, 15 Sep 2015 07:24:07 +0000 (08:24 +0100)
committerFrédéric Demians <f.demians@tamil.fr>
Sun, 29 Nov 2015 20:06:28 +0000 (21:06 +0100)
commit780bc5ecd9be9b645b7fdccc2bcc331dd7df2081
tree3facd131ef9b7e210aeb1021e9ba14e8778771d9
parent7d6a7e0b1b15cef23309a19799a16c6d930e1c08
Bug 14821: Do not list not returned items

On the checkin page, the table is always filled with info of the scanned
barcode, even if the checkin has failed.
When the checkin fails, there is already an error displayed, so there is
no need to keep a row for fails.

Test plan:
Confirm that the failed checkins don't appear anymore in the checkin
table.
- checkin an item which is not issued;
- BlockReturnOfWithdrawnItems is set and item is withdrawn;
- Not returned at the right place;
- privacy=2 and AnonymousPatron not correctly set;

Before this patch this behavior existed only for bad barcode.

Signed-off-by: Frederic Demians <f.demians@tamil.fr>
  I confirm that the checkin table hasn't to be populated with info on items
  which haven't been checked in.

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
(cherry picked from commit 8122df1f8788cbd695e06aa4c1acfa345da8cadc)
Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
circ/returns.pl