Bug 28031: (follow-up) Clarify check methods
authorMartin Renvoize <martin.renvoize@ptfs-europe.com>
Thu, 25 Mar 2021 17:22:29 +0000 (17:22 +0000)
committerJonathan Druart <jonathan.druart@bugs.koha-community.org>
Fri, 9 Apr 2021 13:43:34 +0000 (15:43 +0200)
commit7b9b1b0e2a1810af2905ca77d7a70fc07a72aa26
tree9cb448744d5ef271b0aba949efb159cf604d57a6
parenta48cad0f625dedc9fd881b65a1d40578e4ed80c9
Bug 28031: (follow-up) Clarify check methods

The check methods were positioned under the 'Internal methods' section
of the meodule but are used externally.

It also felt strange to have a noop or die method. Instead, I propose
renaming them to `repeatable_ok` and `unique_ok` and returning a
boolean denoting their state.

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Koha/Patron/Attribute.pm
members/memberentry.pl
opac/opac-memberentry.pl