Bug 5094 auth_by_bind authentication can fail even if given a correct password and...
authorJeremy Crabtree <JeremyC@uta.edu>
Fri, 17 Jun 2011 03:02:50 +0000 (15:02 +1200)
committerChris Cormack <chrisc@catalyst.net.nz>
Fri, 17 Jun 2011 03:05:59 +0000 (15:05 +1200)
commit7bb178e30be74abda82eb4fcaaa873be3dfcc5ef
treef1db8e7f6360aebf5ca194648745998bb4bf5fbf
parent8996faae15420284318344cde78c2858bc4adb3a
Bug 5094  auth_by_bind authentication can fail even if given a correct password and userid

When using

<replicate>0</replicate> <!-- add new users from LDAP to Koha database -->
<update>0</update> <!-- update existing users in Koha database ->
<auth_by_bind>1</auth_by_bind> <!-- set to 1 to authenticate by
binding instead of password comparison, e.g., to use Active Directory -->

Auth_with_ldap attempts to lookup the userid in the LDAP directory to
fill $userldapentry despite it being unneeded in this case.  The information
retrieved will be thrown away, thus there is no need to retrieve it.
This can cause authentication to fail overall even if the initial bind with the
user's credentials succeeded

Signed-off-by: Joe Atzberger <ohiocore@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
C4/Auth_with_ldap.pm