Bug 33992: Only consider the date when auto-expiring problematic recalls
authorAleisha Amohia <aleishaamohia@hotmail.com>
Tue, 13 Jun 2023 05:29:22 +0000 (17:29 +1200)
committerLucas Gass <lucas@bywatersolutions.com>
Wed, 13 Sep 2023 20:54:26 +0000 (20:54 +0000)
commit8023763ecff4af2f3a35da29f218a2aaaed3d6bc
tree27f2dc2a94336b08548ca25341e584a7c02a415f
parente62f7ead03c1705906c4092315200c061e2cb5ff
Bug 33992: Only consider the date when auto-expiring problematic recalls

This patch carries this fix into the misc/cronjobs/recalls/expire_recalls.pl cronjob so that recalls are automatically expired when they have been waiting a problematic number of days, not considering hours, as expected.

To test, follow the test plan from the first patch. This will set you up with a waiting problematic recall.

Run the cronjob manually

perl misc/cronjobs/recalls/expire_recalls.pl

Refresh your 'Recalls awaiting pickup' page. Your problematic recall should be gone/expired.

Expiration dates will apply when expiring any 'unfulfilled' recall i.e. newly requested, overdue to be returned, and awaiting pickup.

Sponsored-by: Auckland University of Technology
Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
(cherry picked from commit 0d2052088ec62654f81154be0b9916b8e8630891)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
(cherry picked from commit 3a5f4d170117e264ed15c8cf40c799ddfd2f6299)
Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com>
(cherry picked from commit 4afe2a2b0a45a672bcae5df445b67ef9b4bb1e65)
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
misc/cronjobs/recalls/expire_recalls.pl