Bug 7567 - Clean up sample news files
authorMark Tompsett <mtompset@hotmail.com>
Fri, 13 Dec 2013 20:51:36 +0000 (15:51 -0500)
committerGalen Charlton <gmc@esilibrary.com>
Mon, 7 Apr 2014 18:05:38 +0000 (18:05 +0000)
commit82a36947f72c542dae4edd967291e7ffe7d8b037
tree10448747b35bc4f1dce65165d742a015def979f5
parent8a9bfd0a1c17cb5dc4b1e9cbd6cb79b349fe9c1b
Bug 7567 - Clean up sample news files

Some files had truncate. Some files had foreign key checks.
Other files had foreign key checks disabled. Some files gave
the column names expressly, and others assumed the fields in
a particular order. Everything was modified to:
- not truncate
- not say utf8 (because it should already be by default)
- not disable foreign key checks (because it should work)
- expressly name the fields (adding fields shouldn't break it)

TEST PLAN
---------
0) Backup opac_news if you care about your news.
1) open mysql client
2) use the koha database
3) Run the following script
TRUNCATE opac_news;
source ~/kohaclone/installer/data/mysql/uk-UA/optional/sample_news.sql
source ~/kohaclone/installer/data/mysql/it-IT/necessari/sample_news.sql
source ~/kohaclone/installer/data/mysql/de-DE/optional/sample_news.sql
source ~/kohaclone/installer/data/mysql/nb-NO/2-Valgfritt/sample_news.sql
source ~/kohaclone/installer/data/mysql/en/optional/sample_news.sql
source ~/kohaclone/installer/data/mysql/pl-PL/optional/sample_news.sql
source ~/kohaclone/installer/data/mysql/es-ES/optional/sample_news.sql
source ~/kohaclone/installer/data/mysql/ru-RU/optional/sample_news.sql
source ~/kohaclone/installer/data/mysql/fr-FR/2-Optionel/sample_news.sql

- Were there errors?
- Did everything add nicely?
    - Not likely, by expressly stating the idnew field, the news
      items in some files would not be added.

4) apply patch
5) try running the script again

- Were there errors?
- Did everything add nicely?
6) Log into the staff client
7) Tools->News
- Do you see the news items added?

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Much needed clean up, making for much more robust and less error prone
sql

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
installer/data/mysql/de-DE/optional/sample_news.sql
installer/data/mysql/en/optional/sample_news.sql
installer/data/mysql/es-ES/optional/sample_news.sql
installer/data/mysql/fr-FR/2-Optionel/sample_news.sql
installer/data/mysql/it-IT/necessari/sample_news.sql
installer/data/mysql/nb-NO/2-Valgfritt/sample_news.sql
installer/data/mysql/pl-PL/optional/sample_news.sql
installer/data/mysql/ru-RU/optional/sample_news.sql
installer/data/mysql/uk-UA/optional/sample_news.sql