Bug 33880: Remove Version param from GB::Barcode->new
authorJake Deery <jake.deery@ptfs-europe.com>
Fri, 2 Jun 2023 13:13:47 +0000 (13:13 +0000)
committerMartin Renvoize <martin.renvoize@ptfs-europe.com>
Wed, 12 Jul 2023 07:01:04 +0000 (08:01 +0100)
commit82cd05381ae7a52da07d392a6a8c09b61703560f
tree1e6ef56052eca8b71f781fd0d0ab32363526ddd8
parentdea8f81e963417955a2797e59fa9222a6912cf59
Bug 33880: Remove Version param from GB::Barcode->new

Looking at the code here
     if (Koha/Auth/TwoFactorAuth.pmoSelf->{Version}){        #--- auto version select
        for(->{Version}=1; ->{Version} <= 40; ++->{Version}) {
            last if ({->{Ecc}}->[->{Version}]
                        >=  + ->[->{Version}]);
        }
   }

in https://metacpan.org/release/KWITKNR/GD-Barcode-1.15/source/Barcode/QRcode.pm#L349

It appears the version parameter is not required, and will default to whatever version has the necessary bits for the input words given

Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
(cherry picked from commit 20d22366813ddbd2c68fc72b609cee88e74e3872)
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Koha/Auth/TwoFactorAuth.pm