Bug 17251: Koha::AuthorisedValues - Remove GetKohaAuthorisedValuesMapping
authorJonathan Druart <jonathan.druart@bugs.koha-community.org>
Wed, 10 Aug 2016 11:29:57 +0000 (12:29 +0100)
committerKyle M Hall <kyle@bywatersolutions.com>
Fri, 21 Oct 2016 15:23:06 +0000 (15:23 +0000)
commit8323db303dd6d1c486574e7750ad58df2c25c744
tree09e8a3a98811bb703a0afb07bdad011963c37806
parent0b6f129ac32e5ea3a2d1357d8e19ba3e24519757
Bug 17251: Koha::AuthorisedValues - Remove GetKohaAuthorisedValuesMapping

This subroutine was only used once in GetItemsForInventory.
It can be replaced with a quite simple search on AV join on
authorised_value_categories and marc_subfield_structures tables.

Note that the "interface" parameter was always set to "staff" and was
useless.

Test plan:
Play with the inventory and confirm that the AV descriptions are
correctly displayed.

The tests in t/db_dependent/Items/GetItemsForInventory.t cover this
change and should still pass.

Signed-off-by: Claire Gravely <claire_gravely@hotmail.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
C4/Items.pm
C4/Koha.pm
Koha/AuthorisedValues.pm
t/db_dependent/Items/GetItemsForInventory.t
t/db_dependent/Koha/GetKohaAuthorisedValuesMapping.t [deleted file]
tools/inventory.pl