Bug 7523: Improve checks for routing permissions
authorKatrin Fischer <Katrin.Fischer.83@web.de>
Sun, 19 Feb 2012 08:37:14 +0000 (09:37 +0100)
committerPaul Poulain <paul.poulain@biblibre.com>
Mon, 27 Feb 2012 17:22:01 +0000 (18:22 +0100)
commit88a2079a48867680af02eb92007eae4c95fe1fb0
tree96991b2318b25ceca97e0d6a1ed5cfb916033ebc
parentcef7c1b40b403c4bcf0c02b13b60d704e4c8cd83
Bug 7523: Improve checks for routing permissions

- system preference RoutingSerials and user permission routing
  should be taken into account
- print routing list should be independent from routing permission

To test, compare to master and check:

1) If system preference RoutingSerials is OFF, routing list functionality is
not visible in the templates.

2) If system preference RoutingSerials is ON, but user doesn't have routing
permission, routing list functionality is not visible in templates,
with exception of 'print list' on the serial collection page.

3) If system preference RoutingSerials is ON and user has routing permissions,
all routing links are visible (serial collection, serials navigation,
result list of serial search)

Additional changes:
Changed labels on templates to match HTML4 rule from coding guidelines.
http://wiki.koha-community.org/wiki/Coding_Guidelines#Upper_and_Lower_cases_in_strings

Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
koha-tmpl/intranet-tmpl/prog/en/includes/serials-menu.inc
koha-tmpl/intranet-tmpl/prog/en/modules/serials/routing-preview.tt
koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-collection.tt
koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-edit.tt
koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-home.tt
serials/routing-preview.pl
serials/serials-collection.pl
serials/subscription-detail.pl