Bug 27796: Centralise payment/transaction type handling
authorMartin Renvoize <martin.renvoize@ptfs-europe.com>
Thu, 25 Feb 2021 17:28:33 +0000 (17:28 +0000)
committerJonathan Druart <jonathan.druart@bugs.koha-community.org>
Fri, 16 Apr 2021 10:28:17 +0000 (12:28 +0200)
commit89cea3d7a791be8f160e492d664b0bfd2bd8d496
tree201fa4ea2ba2471821710c7286e6b6e90bb2c8e4
parentac233efccf089c9981e81bba30554339007729f4
Bug 27796: Centralise payment/transaction type handling

This patch centralises the payment/transaction type select options
handling so the SIP types are properly in all cases.

Test plan
1) Check that SIP payment types are properly hidden on the following
   modals.
1a) Refund modal on the borrower account page (The 'Account credit'
option should appear here)
1b) Payout modal on borrower account page
1c) Payment via paycollect
1d) Payment via point of sale
1e) Refund via point of sale, register details page (The 'Account
credit' option should only appear for debts associated to a patron and
not for payments accepted via point of sale)
2) Signoff

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
koha-tmpl/intranet-tmpl/prog/en/includes/payments.inc [deleted file]
koha-tmpl/intranet-tmpl/prog/en/includes/transaction_types.inc [new file with mode: 0644]
koha-tmpl/intranet-tmpl/prog/en/modules/members/boraccount.tt
koha-tmpl/intranet-tmpl/prog/en/modules/members/paycollect.tt
koha-tmpl/intranet-tmpl/prog/en/modules/pos/pay.tt
koha-tmpl/intranet-tmpl/prog/en/modules/pos/register.tt
members/boraccount.pl
pos/register.pl