Bug 14185: Undefined $limit causes warn in opac/opac-readingrecord.pl
authorAleisha <aleishaamohia@hotmail.com>
Tue, 12 May 2015 03:01:35 +0000 (03:01 +0000)
committerLiz Rea <wizzyrea@gmail.com>
Sun, 7 Jun 2015 22:24:43 +0000 (10:24 +1200)
commit9292bebbdd041788acdecda3cf3265169e8e231d
treed7363d8e0fadd32f30d3fafead30d576c1d274a1
parent5e48a461dbcd102ebc76c7552ed5b695861d97f7
Bug 14185: Undefined $limit causes warn in opac/opac-readingrecord.pl

This patch sets $limit to be an empty string.

Test plan
=========

1/ login into the opac using your user account credentials
2/ in a terminal, run a `tail -f ` on your instance's opac-error.log
3/ go back to the opac, click on 'your reading history' tab to go to
   opac-readingrecord.pl
4/ notice the warning - "opac-readingrecord.pl: Use of uninitialized
   value $limit" appear in the `tail`ed opac-error.log
5/ apply the patch
6/ reload the page (opac-readingrecord.pl)
7/ page works but the warning in step #4 is no longer logged
8/ run qa test (i.e. koha-qa.pl -c 1 -v 2), there should be no error

Remarks: Testing result match expected test plan output. The QA tests
         pass with "OK" for the commit.

Signed-off-by: Indranil Das Gupta (L2C2 Technologies) <indradg@gmail.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
(cherry picked from commit fd14184873e707236150e368f39b19a6992760b8)
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Liz Rea <wizzyrea@gmail.com>
opac/opac-readingrecord.pl