Bug 23382: Fix logic in C4::Circulation::CanBookBeIssued
authorMartin Renvoize <martin.renvoize@ptfs-europe.com>
Fri, 16 Aug 2019 07:32:55 +0000 (08:32 +0100)
committerLucas Gass <lucas@bywatersolutions.com>
Fri, 17 Jan 2020 14:54:53 +0000 (14:54 +0000)
commit9744690da41ba2977805806c937ebd3714a1d131
tree5e7209a2b1f92cb71fdcc5fcad07a19f01f97607
parent846bab1a7cde25d0921fbcc5f9395b03757849b3
Bug 23382: Fix logic in C4::Circulation::CanBookBeIssued

It looks like over progressive rebases of bug 20912 a clause was lost
within CanBookBeIssued such that a fatal error may be triggered if an
item with no corresponding itemtype was passed into the routine.

Additionally the we were passing a Koha::Library object to CalcDateDue
rather than a branchcode which resulted in a different duedate being
used in 'CanBookBeIssued' when compared to 'AddIssue'.

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
(cherry picked from commit f8e2c489cb668aab9e7484c2dd67c1c05f37b2a5)

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
C4/Circulation.pm