Bug 24603: (follow-up) Update to double entry accounting
authorMartin Renvoize <martin.renvoize@ptfs-europe.com>
Fri, 10 Jul 2020 13:49:35 +0000 (14:49 +0100)
committerJonathan Druart <jonathan.druart@bugs.koha-community.org>
Tue, 10 Nov 2020 14:00:14 +0000 (15:00 +0100)
commit9c709b871f5f5c2887eefb81a3f93a8ad76fb8d0
tree3f13aabc8534732fe42afd835a5018d6c805bf5d
parent8d2259b67443f75675733d41773d153d889dffd7
Bug 24603: (follow-up) Update to double entry accounting

This patch updates the logic to create a cancellation accountline and
apply it to the charge line so we correction record the transaction in
terms of double entry accounting standards.

Test plan:
1. Go to a patron's accounting section
2. Create a manual invoice
3. In Transactions tab, you should see a 'Cancel charge' button. Click
   on it. It should now be marked as cancelled
4. A cancellation line should be associated with the original charge.
5. Create another manual invoice
6. Pay it (partially or fully)
7. Notice that the 'Cancel charge' button is not available
8. Void the payment
9. 'Cancel charge' button is available again. Click on it and verify
   that it still works
10. prove t/db_dependent/Koha/Account/Lines.t

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
https://bugs.koha-community.org/show_bug.cgi?id=24063

Bug 24603: Fix number of unit tests

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
https://bugs.koha-community.org/show_bug.cgi?id=24063

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Koha/Account/Line.pm
installer/data/mysql/atomicupdate/bug_24603.perl [new file with mode: 0644]
installer/data/mysql/mandatory/account_credit_types.sql
installer/data/mysql/mandatory/account_offset_types.sql
koha-tmpl/intranet-tmpl/prog/en/modules/members/boraccount.tt
members/cancel-charge.pl
t/db_dependent/Koha/Account/Line.t