Bug 25002: JS Includes should be wrapped with template comments
authorOwen Leonard <oleonard@myacpl.org>
Fri, 27 Mar 2020 23:35:51 +0000 (23:35 +0000)
committerMartin Renvoize <martin.renvoize@ptfs-europe.com>
Wed, 29 Apr 2020 16:15:20 +0000 (17:15 +0100)
commit9ea7fbcb30bf4b4879d4eb68c940316024c08760
tree63636a8d1c65bee56cb1f0e09ccbf9d5c847ed79
parentf0cbb2063aa17b9832cc89bdd7a532d826dc48c8
Bug 25002: JS Includes should be wrapped with template comments

This patch adds HTML comments to Template::Toolkit include files which
contain <script> tags so that it is clear where the embedded scripts can
be found in the code.

To test, apply the patch and view source on the following pages to
verify the presence of the comments:

Acquisitions home page:
  - acquisitions-toolbar.inc
  - validtor-strings.inc
  - js_includes.inc
  - format-price.inc
Acquisitions -> Add order from new record,
Acquisitions -> Receive order:
  - additem.js.inc
Cataloging -> Add/Edit item:
  - columns_settings.inc
  - strings.inc
  - select2.inc
  - calendar.inc
  - str/cataloging_additem.inc
Authorities home page:
  - authorities_js.inc
Bibliographic detail page:
  - catalog-strings.inc
Cataloging -> Advanced editor:
  - cateditor-ui.inc
  - cateditor-widgets-marc21.inc
Administration -> Item types:
  - greybox.inc
ILL requests:
  - ill-list-table-strings.inc
Web installer
  - installer-intranet-bottom.inc
Web installer -> Onboarding
  - installer-strings.inc
Lists -> List contents -> Merge records
  - merge-record-strings.inc
Patrons -> Patron -> Change password
  - password_check.inc
  - str/members-menu.inc
Patrons -> Patron -> Print summary
  - slip-print.inc
Circulation -> Check out
  - timepicker.inc
Administration -> System preferences:
  - str/tinymce_i18n.inc
  - wysiwyg-systempreferences.inc
Cataloging -> Z39.50 Search:
  - z3950_search.inc

Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
27 files changed:
koha-tmpl/intranet-tmpl/prog/en/includes/acquisitions-toolbar.inc
koha-tmpl/intranet-tmpl/prog/en/includes/additem.js.inc
koha-tmpl/intranet-tmpl/prog/en/includes/authorities_js.inc
koha-tmpl/intranet-tmpl/prog/en/includes/calendar.inc
koha-tmpl/intranet-tmpl/prog/en/includes/catalog-strings.inc
koha-tmpl/intranet-tmpl/prog/en/includes/cateditor-ui.inc
koha-tmpl/intranet-tmpl/prog/en/includes/cateditor-widgets-marc21.inc
koha-tmpl/intranet-tmpl/prog/en/includes/columns_settings.inc
koha-tmpl/intranet-tmpl/prog/en/includes/format_price.inc
koha-tmpl/intranet-tmpl/prog/en/includes/greybox.inc
koha-tmpl/intranet-tmpl/prog/en/includes/ill-list-table-strings.inc
koha-tmpl/intranet-tmpl/prog/en/includes/installer-intranet-bottom.inc
koha-tmpl/intranet-tmpl/prog/en/includes/installer-strings.inc
koha-tmpl/intranet-tmpl/prog/en/includes/js-date-format.inc
koha-tmpl/intranet-tmpl/prog/en/includes/js_includes.inc
koha-tmpl/intranet-tmpl/prog/en/includes/merge-record-strings.inc
koha-tmpl/intranet-tmpl/prog/en/includes/password_check.inc
koha-tmpl/intranet-tmpl/prog/en/includes/select2.inc
koha-tmpl/intranet-tmpl/prog/en/includes/slip-print.inc
koha-tmpl/intranet-tmpl/prog/en/includes/str/cataloging_additem.inc
koha-tmpl/intranet-tmpl/prog/en/includes/str/members-menu.inc
koha-tmpl/intranet-tmpl/prog/en/includes/str/tinymce_i18n.inc
koha-tmpl/intranet-tmpl/prog/en/includes/strings.inc
koha-tmpl/intranet-tmpl/prog/en/includes/timepicker.inc
koha-tmpl/intranet-tmpl/prog/en/includes/validator-strings.inc
koha-tmpl/intranet-tmpl/prog/en/includes/wysiwyg-systempreferences.inc
koha-tmpl/intranet-tmpl/prog/en/includes/z3950_search.inc