Bug 28581: Add 'from_email_address' method and use in Koha::Patron
authorMartin Renvoize <martin.renvoize@ptfs-europe.com>
Thu, 17 Jun 2021 08:54:46 +0000 (09:54 +0100)
committerJonathan Druart <jonathan.druart@bugs.koha-community.org>
Wed, 23 Jun 2021 13:09:55 +0000 (15:09 +0200)
commita7c202de1c97438a32b86a309a449e7c427f77d3
treeab20e7d268f74e795e0ab600e1297df37e9bea4a
parent7293802becd3741a1f042f233ff614792c9e480f
Bug 28581: Add 'from_email_address' method and use in Koha::Patron

This patch adds a new 'from_email_address' method to Koha::Library to
return the appropriate email address to use as the 'from' field for
email notices from the library.

We then update Koha::Patron->queue_notice to use this new method instead
of the incorrect inbound_email_address.

I also update the POD for inbound_email_address to clarify it's use
case.

Test plan

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Koha/Library.pm
Koha/Patron.pm
t/db_dependent/Koha/Libraries.t