Fines fixes: apparent problems with fines prevent processing.
authorJoe Atzberger <joe.atzberger@liblime.com>
Tue, 26 Aug 2008 03:57:01 +0000 (22:57 -0500)
committerGalen Charlton <galen.charlton@liblime.com>
Sat, 30 Aug 2008 01:31:41 +0000 (20:31 -0500)
commitaa4c6ff62fff4f49a4e0e67ae1616d0f04c95275
tree5bf398d73aa8adb30793bffc2dc668416ac8a0d5
parent9eb1465b2874a8a65195065bed083d26614ca287
Fines fixes: apparent problems with fines prevent processing.

CalcFine returned values that mismatched expectations in fines.pl.

fines.pl refactored: added debugging, prevent needless recreation of
Calendar objects by storing them in hash by branch.
Still outstanding problems with fines, including the output of a field
that has no other references in Koha (so is always undef) and the
incorrect description of FinesMode.

Calendar exported "new" erroneously.  I also cleaned up the queries to
avoid needlessly compiling additional statement handles.

Please test and consider application to 3.0 maintenance.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
C4/Calendar.pm
C4/Overdues.pm
misc/cronjobs/fines.pl
t/lib/KohaTest/Calendar.pm