Bug 15344: Remove unucessary call to GetMemberDetails
authorJonathan Druart <jonathan.druart@bugs.koha-community.org>
Wed, 9 Dec 2015 17:00:10 +0000 (17:00 +0000)
committerKyle M Hall <kyle@bywatersolutions.com>
Wed, 30 Dec 2015 11:53:18 +0000 (11:53 +0000)
commitac541e0fa1c11254e110d94eed64c358e02e8aab
tree7993f272fa9018470b7174eb717dcae663226a57
parent3a7dd6c07c98bf97c817186d11ae1baaf585ea34
Bug 15344: Remove unucessary call to GetMemberDetails

This subroutine does a lot a processing and should only be called when
necessary.
In the get_template_and_user subroutine (so called from any pages of
Koha), it is call to pass the branchcode, title, firstname, surname and
borrowernumber values for the logged in user.
This subroutine calls GetMemberAccountRecords which retrieve the items
infos for all accountlines entries of the logged in user.
On members/members.pl, let's say you have 74 entries in the accountlines
tables, the page will execute 115 SELECT instead of 35 if you don't have any
accountlines entries.
With this patch, the number of SELECT is always 31.

To test this patch you should have technical skills to know what to do.

Note that USER_INFO was an array of... 1 element. Now it's a hashref.

Signed-off-by: Marc VĂ©ron <veron@veron.ch>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
12 files changed:
C4/Auth.pm
admin/aqbudgets.pl
admin/aqplan.pl
koha-tmpl/intranet-tmpl/prog/en/includes/cateditor-ui.inc
koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt
koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbooks.tt
koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead.inc
koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-downloadshelf.tt
koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-reserve.tt
koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shareshelf.tt
koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt
koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-suggestions.tt