Bug 28912: Prevent Pseudonymization to be set if bcrypt_settings not set
authorJonathan Druart <jonathan.druart@bugs.koha-community.org>
Fri, 27 Aug 2021 14:56:08 +0000 (16:56 +0200)
committerJonathan Druart <jonathan.druart@bugs.koha-community.org>
Thu, 9 Sep 2021 08:59:38 +0000 (10:59 +0200)
commitac9dff5509448d733026ee4b7f8dde8b1a6b9394
tree1803c99c55a7db9bea528a7b60af704afa5f3346
parent641c4ffa97a6060c939934ef21d9b59ddd9a05eb
Bug 28912: Prevent Pseudonymization to be set if bcrypt_settings not set

If Pseudonymization is set but the bcrypt_settings config used by the
feature is not set, then there is an ugly 500 on checking out.

bad bcrypt settings at /kohadevbox/koha/Koha/PseudonymizedTransaction.pm line 116.

However it's pretty hard to handle correctly this exception (and that's
why it hasn't be done initially). However we could prevent the pref to
be turned on if the config entry is not present.

Test plan:
Remove the bcrypt_settings from the config
Try to turn the syspref on
Add the config
Try to turn the syspref on/off

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
JD amended patch: fix qa failures

Signed-off-by: Joonas Kylmälä <joonas.kylmala@iki.fi>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
admin/preferences.pl
koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences.tt