Bug 24236: Fix pagination to use query_cgi
authorNick Clemens <nick@bywatersolutions.com>
Fri, 13 Dec 2019 16:08:16 +0000 (16:08 +0000)
committerLucas Gass <lucas@bywatersolutions.com>
Thu, 13 Feb 2020 20:11:03 +0000 (20:11 +0000)
commitafab0af590c320a1d57e4ea1305a4ff83f988851
tree14037bb2ce05929ad77aa49d73ae6592bb4da070
parent1904e1dfccb21c5f8de163090eb85d478c02a032
Bug 24236: Fix pagination to use query_cgi

This is still wrong, we should use page-numbers.inc, but that is a larger refactoring
This patch fixes non-QueryParser searches by simple getting an using the escaped query (query_cgi)

For QueryParser, we do what the QP code does, just uri escape the query - the way that SimpleSearch does the query parsing instead of the usual buildQuery suggest to me that we should probably switch all of this to use the general Zebra search.

The issues with reservoir should be their own bug

To test:
1 - Search for cat in cataloging search
2 - Get results and see you can paginate
3 - Search for "cat"
4 - Get results but subsequent pages empty
5 - Apply patch
6 - Repeat search for "cat"
7 - You can paginate
8 - Enable UseQueryParser syspref (don't worry about installing)
9 - Confirm can still search with quotes and paginate

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: George Williams <george@nekls.org>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Joy Nelson <joy@bywatersolutions.com>
(cherry picked from commit c2182118e130ac246b1f5ed790fb1659789e2fe5)

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
cataloguing/addbooks.pl