Bug 33597: Fix deleting cookie for holdfor(club)
authorMarcel de Rooy <m.de.rooy@rijksmuseum.nl>
Mon, 24 Apr 2023 10:35:26 +0000 (10:35 +0000)
committerLucas Gass <lucas@bywatersolutions.com>
Mon, 15 May 2023 22:24:59 +0000 (22:24 +0000)
commitb8fb6aab761187795186d97209c3972e046b7786
tree91376b1d04c751c7dc839c5278e4aa0035bdb64b
parent18471b559dc94d65ba164fc00b03cc408c84b6cb
Bug 33597: Fix deleting cookie for holdfor(club)

Resolve:
Cookie “holdfor” does not have a proper “SameSite” attribute value. Soon, cookies without the “SameSite” attribute or with an invalid value will be treated as “Lax”. This means that the cookie will no longer be sent in third-party contexts. If your application depends on this cookie being available in such contexts, please add the “SameSite=None“ attribute to it.

Did not see warning for holdforclub. But since it is created with Lax, we should remove it with Lax.

Test plan:
Similar to previous patch. Check console on logout page.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
(cherry picked from commit 7e5e311cb0c88b9223ce98d685668962edc7baee)
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
(cherry picked from commit d8567143eea4dde52cce0c856e3c12a6154eda0b)
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
koha-tmpl/intranet-tmpl/prog/js/pages/results.js
koha-tmpl/intranet-tmpl/prog/js/staff-global.js