Bug 25189: Don't create authority if results found
authorNick Clemens <nick@bywatersolutions.com>
Tue, 28 Apr 2020 15:34:20 +0000 (15:34 +0000)
committerVictor Grousset/tuxayo <victor@tuxayo.net>
Fri, 18 Dec 2020 22:14:37 +0000 (23:14 +0100)
commitbceeea6fa913385b7bbda4419ee36eee07740cc9
tree24f705735d1d7150bab3be99df7187a3e9e36aa8
parente5f70757053094658d8e54c56d947cc7fa58adf9
Bug 25189: Don't create authority if results found

Automatic authority creation assumes that if we don't match we need a new authority.

Using the Default linker, however, we don't match if there exists more than one match.
This leads to repeatedly generating authorities once there is a duplicate in the system

We shoudl instead only create a new authority if there are no results

To test:
1 - Set Linker Module to 'Default'
2 - Enable  AutoCreateAuthorities  and  BiblioAddsAuthorities and  CatalogModuleRelink and LinkerRelink
3 - Add two copies of a single authority via Z39
4 - Add a heading for that authority to a bib record
5 - Save the record and note a new authority is generated
6 - Repeat and see another is generated
7 - Apply patch
8 - Restart all the things
9 - Save the record again, no new authority created

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
(cherry picked from commit 980419ed15cd4e5ae8be552218f939f5faea18c4)

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
(cherry picked from commit e5baeac0fdbc5fc83256effeff304e736c7dc154)
Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>
C4/Biblio.pm
C4/Linker/Default.pm