Bug 3522 Refactor Create Update Delete letter for consistency and readability
authorColin Campbell <colin.campbell@ptfs-europe.com>
Tue, 11 Aug 2009 16:43:02 +0000 (17:43 +0100)
committerGalen Charlton <gmcharlt@gmail.com>
Tue, 11 Aug 2009 21:51:43 +0000 (17:51 -0400)
commitc1d4bb641bd0dcf27fbd1e14004c19c28edc76e6
tree40d835cd473d94e0a9144c25210b6b0100f4202e
parent7f7dfa0a11dd5d983deca2c18715b5126a11b12c
Bug 3522 Refactor Create Update Delete letter for consistency and readability

Fixed inconsistent usuage of primary key in delete
Refactored:
Moved operations to separate subroutines to clarify data flow
Removed unnecessary redirects to self
Renamed confusingly named else variable passed to template
Other changes for code clarity
NB Outstanding:
database reading/writing should live in appropriate module
not duplicate it here.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
koha-tmpl/intranet-tmpl/prog/en/modules/tools/letter.tmpl
tools/letter.pl