Bug 27011: Remove unused $name variable
authorAmy King <amyking386@gmail.com>
Tue, 19 Jan 2021 03:27:27 +0000 (03:27 +0000)
committerVictor Grousset/tuxayo <victor@tuxayo.net>
Tue, 2 Feb 2021 01:34:39 +0000 (02:34 +0100)
commitc3f3015840dc737c1476534c089ac68c05cf1a3d
treef5298bd3ee5e039dcecad13a6559f3dd2daaf83f
parent213bb9c383793879af1e1e6e8f1c4a74feb63504
Bug 27011: Remove unused $name variable

The variable is no longer used in the template, it has been removed by:

  commit 76eb3a0549efe4c1f1557071a6cb4b33d4bd3e4d
  Bug 18789: (follow-up) Pass a Koha::Patron object from returns.pl

-            <td>[% name %]</td>
+            <td>[% INCLUDE 'patron-title.inc' patron=patron %]</td>

We can simply remove the $name variable from the controller script.

Test Plan:
1. Check out a book
2. Check in a book
3. Note what happens
4. Apply patch
5. Repeat step 1-2
6. Note that it doesn't break and everything still works

JD Amended patch: fix commit message

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
(cherry picked from commit 113992e620095aac59253cf653acfa47f1ec7768)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
(cherry picked from commit 6a4541776e4b8f6176de7ba85e2f2011574ddd5c)

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
(cherry picked from commit 5f21cda35b9ad7ed21d2521b7384f7e7256d49de)
Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>
circ/returns.pl