Bug 15870: Follow-up of filter and tests
authorMark Tompsett <mtompset@hotmail.com>
Fri, 4 Mar 2016 22:04:37 +0000 (17:04 -0500)
committerBrendan A Gallagher <brendan@bywatersolutions.com>
Thu, 24 Mar 2016 20:15:40 +0000 (20:15 +0000)
commitc9170233c976b3ac05f8712fdc2c9aa25973f34f
tree25b3b47fedf3df6c6c063e570a3b2db7c0023ba5
parent590f174560029db99a5123597418675959936a07
 Bug 15870: Follow-up of filter and tests

This patch:
- improves perlcritic messages in the filter and tests.
- changes should display logic to should hide logic
  to simplify filter.
- perltidies the scripts
- debugs the issues outstanding on the comprehensive tests
  provided in the second commit.

Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
Koha/Filter/MARC/ViewPolicy.pm
t/db_dependent/Filter_MARC_ViewPolicy.t